Skip to content

fix(map): keep compass icon visible while following bearing #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Jun 3, 2026
Merged

fix(map): keep compass icon visible while following bearing #5728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion feature/map/src/commonMain/kotlin/org/meshtastic/feature/map/component/MapControlsOverlay.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import org.meshtastic.core.ui.icon.MeshtasticIcons
import org.meshtastic.core.ui.icon.MyLocation
import org.meshtastic.core.ui.icon.Refresh
import org.meshtastic.core.ui.icon.Tune
import org.meshtastic.core.ui.theme.StatusColors.StatusBlue
import org.meshtastic.core.ui.theme.StatusColors.StatusRed

/**
Expand Down Expand Up @@ -127,9 +128,11 @@ fun MapControlsOverlay(

@Composable
private fun CompassButton(onClick: () -> Unit, bearing: Float, isFollowing: Boolean) {
// Tint, not `primary` — tinting the icon `primary` painted it the same color as its own primary-colored
// button background, making the compass disappear while following.
val iconTint =
when {
isFollowing -> MaterialTheme.colorScheme.primary
isFollowing -> MaterialTheme.colorScheme.StatusBlue
bearing == 0f -> MaterialTheme.colorScheme.StatusRed
else -> null
}
Expand Down
Loading