refactor(node): migrate to non-deprecated Vico chart APIs#5737
Merged
Conversation
Vico 3.2.1 deprecated two APIs used in the node metrics charts:
- lineSeries → lineModel (drop-in rename; the deprecated function just
delegates to lineModel)
- the rememberCartesianChart getXStep lambda now receives (model, minX,
maxX); updated the BaseMetricChart callback to { model, _, _ -> ... }
with unchanged logic
Clears the deprecation warnings from the build log. No behavior change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Vico 3.2.1 deprecated two charting APIs used across the node metrics charts. This migrates to their replacements:
lineSeries→lineModel— a drop-in rename (the deprecatedlineSeriessimply delegates tolineModel). Updated the import + all call sites inDeviceMetrics,EnvironmentCharts,HostMetricsChart,PaxMetrics,PowerMetrics,SignalMetrics, andTracerouteChart.rememberCartesianChartgetXSteplambda — the new overload's lambda receives(model, minX, maxX). UpdatedBaseMetricChartfrom{ model -> ... }to{ model, _, _ -> ... }; the 60-second floor logic is unchanged.Why
These were the deprecation warnings flooding the Kotlin compiler output for
feature/node. No behavior change — purely clearing deprecated API usage.Reviewer notes
spotlessApply spotlessCheck detektpass and:feature:node:allTestsis green (627 tests). No remaininglineSeries/getXStepdeprecation warnings.🤖 Generated with Claude Code