Support additional relays provided by the node#1982
Closed
alecperkins wants to merge 1 commit into
Closed
Conversation
11 tasks
The firmware now forwards additional copies of an inbound packet (same packet id, relayed by a different node) so the app can track multiple relayers. SwiftData's unique constraint on MessageEntity.messageId upserts rather than throws, so re-saving a duplicate copy succeeded, left messageSaved == true, and fired the message notification a second time. textMessageAppPacket now looks up an existing message by packet id before inserting. When one is found, the copy is treated as an additional relay: relayNode stays pinned to the first relayer seen and the relays count is incremented, then it returns without inserting a new message or scheduling a notification. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Changed to draft, code is not even merged into develop in the firmware. |
Member
|
The firmware pull that this depends on needs to be reworked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adds support for receiving additional relay info about the same packet from the firmware.
Why did it change?
meshtastic/firmware#10767 provides multiple notices of the same packet for each overheard transmission of the packet. This causes duplicate push notifications for the packet as each repeat is heard.
How is this tested?
I connected the current app (2.7.14 2062) to a node running the changed firmware, and observed the duplicate notifications. I built and installed the iOS app onto an iPhone 16 Pro (iOS 18) and connected it to the node to confirm it does not show duplicates now, and correctly counts the relays.
Screenshots/Videos (when applicable)
Checklist
docs/user/ordocs/developer/, and updated accordingly (see copilot-instructions.md for the view → doc page mapping). If no doc update is needed, add theskip-docs-checklabel.