fix: send message on main Return key in MUI composer (X11/native-tft)#345
Merged
Merged
Conversation
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe message input handler converts raw carriage-return keyboard events into LVGL ready events, allowing physical Enter to trigger the existing message-send logic. ChangesMessage submission
Estimated code review effort: 2 (Simple) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LVGL's X11 input driver maps only XK_KP_Enter to LV_KEY_ENTER; the main Return key falls through XLookupString as a raw '\r', which the one-line message textarea silently discards (lv_textarea.c one_line filter). As a result, typing worked but pressing Enter never sent the message - only the on-screen keyboard checkmark did (lv_keyboard sends LV_EVENT_READY directly). Handle LV_EVENT_KEY == '\r' in ui_event_message_ready and route it into the existing LV_EVENT_READY send logic. Keypad Enter is unaffected (its LV_KEY_ENTER already triggers a nested LV_EVENT_READY from the textarea class handler, and '\n' != '\r' avoids any double-send). The space+return CR_REPLACEMENT newline trick keeps working, now also with the physical Return key.
p0ns
force-pushed
the
fix/x11-return-key-send
branch
from
July 17, 2026 16:06
7aeb752 to
26ac5de
Compare
mverch67
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
On the
native-tft(X11) build, the main Return key arrives as a raw'\r'because LVGL's X11 driver only mapsXK_KP_EntertoLV_KEY_ENTER. The one-line composer textarea silently discards'\r', soLV_EVENT_READYnever fires and the message is never sent — only the on-screen keyboard checkmark (or keypad Enter) worked.Change
ui_event_message_readyis already registered withLV_EVENT_ALL, so it receives theLV_EVENT_KEYevent after the textarea class handler drops the char. This PR handlesLV_EVENT_KEY == '\r'there and routes it into the existingLV_EVENT_READYsend logic.LV_KEY_ENTER('\n'), which already triggers a nestedLV_EVENT_READYfrom the textarea class handler, and'\n' != '\r'so this handler ignores them.CR_REPLACEMENTnewline trick keeps working, now also with the physical Return key.TFTView_320x240.cpp.See #344 for the full diagnosis.
Summary by CodeRabbit