Skip to content

feat(lang): add Hungarian language#347

Merged
mverch67 merged 11 commits into
meshtastic:masterfrom
pisti87:pisti87-patch-1
Jul 16, 2026
Merged

feat(lang): add Hungarian language#347
mverch67 merged 11 commits into
meshtastic:masterfrom
pisti87:pisti87-patch-1

Conversation

@pisti87

@pisti87 pisti87 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

this patch is full. now okay

Summary by CodeRabbit

  • New Features
    • Added Hungarian (hu) language support across the interface.
    • Translated UI text for settings (including advanced), reboot/shutdown prompts, mesh/node discovery and statistics, chat/message notifications, input and filtering, and display controls (brightness, timeout, calibration, theme).
    • Included Hungarian pluralization plus dynamic placeholders for counts and time-based messages, along with uptime/heap/LVGL display strings and SD-card error messages.

@CLAassistant

CLAassistant commented Jul 16, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mverch67
❌ pisti87
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f8c01f0-f9f7-476e-9648-e70c37077b49

📥 Commits

Reviewing files that changed from the base of the PR and between f8d0b1a and 79269ad.

📒 Files selected for processing (2)
  • locale/hu.yml
  • locale/lv_i18n.c
🚧 Files skipped from review as they are similar to previous changes (1)
  • locale/hu.yml

📝 Walkthrough

Walkthrough

Added a Hungarian translation catalog with formatted and pluralized messages, defined its i18n data and plural-selection rule, and registered the Hungarian locale in the bundled language pack.

Changes

Hungarian localization

Layer / File(s) Summary
Hungarian catalog and locale registration
locale/hu.yml, locale/lv_i18n.c
Adds Hungarian UI translations, placeholders, multiline messages, plural forms, i18n tables, a plural-selection function, locale metadata, and bundled language-pack registration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A bunny hops through words so bright,
Hungarian labels bloom just right.
Plurals dance and placeholders play,
Guiding the mesh throughout the day.
“Üdv!” the rabbit cheers with glee.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding Hungarian language support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pisti87
pisti87 marked this pull request as draft July 16, 2026 06:28
@pisti87
pisti87 marked this pull request as ready for review July 16, 2026 06:28
@pisti87

pisti87 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

All errors have been fixed

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locale/hu.yml`:
- Line 27: Update the translation value for the “Language: English” key to
preserve the English language name, using the Hungarian translation “Nyelv:
angol” instead of “Nyelv: magyar”.
- Line 16: Update the static “Modem Preset: LONG FAST” translation entry to use
the Hungarian label “Modem profil: LONG FAST”, matching the translated dynamic
form.
- Line 4: Update the localized node-count text in the affected locale entry to
use the singular “node” form for a count of one, matching the singular wording
used by the related entries at lines 157–158 while preserving the plural form
for larger counts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27101d55-e1bb-4366-a010-98b2253a6b3b

📥 Commits

Reviewing files that changed from the base of the PR and between effbb92 and 21123db.

📒 Files selected for processing (1)
  • locale/hu.yml

Comment thread locale/hu.yml Outdated
Comment thread locale/hu.yml Outdated
Comment thread locale/hu.yml Outdated
@pisti87
pisti87 marked this pull request as draft July 16, 2026 06:37
@pisti87
pisti87 marked this pull request as ready for review July 16, 2026 06:37

@pisti87 pisti87 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish

@pisti87
pisti87 marked this pull request as draft July 16, 2026 16:35
@pisti87
pisti87 marked this pull request as ready for review July 16, 2026 16:36
@pisti87
pisti87 marked this pull request as draft July 16, 2026 19:08
@pisti87
pisti87 marked this pull request as ready for review July 16, 2026 19:08
@coderabbitai coderabbitai Bot mentioned this pull request Jul 16, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locale/lv_i18n.c`:
- Around line 1531-1534: Update the Hungarian source translation entry for “%d
of %d nodes online” so its plural form uses the singular Hungarian noun,
matching the translation in hu_plurals_one; do not edit only the generated
locale/lv_i18n.c output, and preserve the existing other translations.
- Around line 3524-3528: Add a meshtastic_Language_HUNGARIAN case to
TFTView_320x240.cpp::setLocale that calls lv_i18n_set_locale("hu"), matching the
existing language mappings and enabling Hungarian UI selection.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 77118d38-4df2-4191-a80b-ff413ecffb55

📥 Commits

Reviewing files that changed from the base of the PR and between 7a40a70 and f8d0b1a.

📒 Files selected for processing (2)
  • locale/hu.yml
  • locale/lv_i18n.c
🚧 Files skipped from review as they are similar to previous changes (1)
  • locale/hu.yml

Comment thread locale/lv_i18n.c
Comment thread locale/lv_i18n.c
@mverch67
mverch67 merged commit 33917d5 into meshtastic:master Jul 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants