Skip to content

Pisti87 patch 4#349

Closed
pisti87 wants to merge 3 commits into
meshtastic:masterfrom
pisti87:pisti87-patch-3
Closed

Pisti87 patch 4#349
pisti87 wants to merge 3 commits into
meshtastic:masterfrom
pisti87:pisti87-patch-3

Conversation

@pisti87

@pisti87 pisti87 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added complete Hungarian language support across the interface.
    • Translated device status, connectivity, settings, display controls, chat, identity, and SD card messages.

pisti87 added 3 commits July 16, 2026 15:34
feat(lang): add Hungarian language
Update language label from English to Hungarian
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds locale/hu.yml, providing Hungarian translations for device status, settings, configuration, screen controls, chat workflows, telemetry, alerts, and SD card or storage messages.

Changes

Hungarian localization

Layer / File(s) Summary
Core UI and configuration translations
locale/hu.yml
Adds Hungarian strings for startup and device status, navigation, settings, backup and restore flows, WiFi, display, language, roles, channels, and modem options.
Interaction and storage translations
locale/hu.yml
Adds Hungarian strings for telemetry, chat workflows, controls, dynamic placeholders, alerts, pluralized counts, and SD card or storage states.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Poem

A bunny hops through Hungarian words,
Translating screens, chats, and boards.
Status, settings, storage too—
Every message blooms anew.
“Pawsome!” says the locale crew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and does not describe the actual change, which adds Hungarian localization strings. Rename the PR to clearly describe the main change, such as adding Hungarian language support or a Hungarian translation catalog.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pisti87
pisti87 marked this pull request as ready for review July 16, 2026 19:31

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locale/hu.yml`:
- Line 4: Update the Hungarian translations for the “1 of 1 nodes online” entry
and its plural forms in locale/hu.yml, replacing the empty and English values
with non-empty Hungarian text while preserving every %d placeholder.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 328fad27-b32a-40c2-9ae8-f2948bd36ec8

📥 Commits

Reviewing files that changed from the base of the PR and between effbb92 and 2079e02.

📒 Files selected for processing (1)
  • locale/hu.yml

Comment thread locale/hu.yml
hu:
Reboot into BaseUI?: Újraindítás BaseUI módba?
no new messages: nincs új üzenet
1 of 1 nodes online: ~

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

sed -n '1,12p;150,165p' locale/hu.yml | cat -n

Repository: meshtastic/device-ui

Length of output: 1393


🏁 Script executed:

nl -ba locale/hu.yml | sed -n '1,220p'

Repository: meshtastic/device-ui

Length of output: 194


🏁 Script executed:

python3 - <<'PY'
from pathlib import Path
p = Path('locale/hu.yml')
for i, line in enumerate(p.read_text(encoding='utf-8').splitlines(), 1):
    if 'nodes online' in line or i <= 8 or 145 <= i <= 170:
        print(f"{i:4d}: {line}")
PY

Repository: meshtastic/device-ui

Length of output: 1682


Complete the online-node translations. locale/hu.yml:4,156-158 still has 1 of 1 nodes online: ~, and the plural forms are still English (node/nodes). Add non-empty Hungarian text for all forms and keep the %d placeholders.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@locale/hu.yml` at line 4, Update the Hungarian translations for the “1 of 1
nodes online” entry and its plural forms in locale/hu.yml, replacing the empty
and English values with non-empty Hungarian text while preserving every %d
placeholder.

@mverch67 mverch67 closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants