Skip to content

feat: share channels with interoperable QR URLs#351

Draft
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/channelset-share-url
Draft

feat: share channels with interoperable QR URLs#351
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/channelset-share-url

Conversation

@RCGV1

@RCGV1 RCGV1 commented Jul 19, 2026

Copy link
Copy Markdown
Member

Summary

  • generate canonical ChannelSet QR URLs instead of PSK-only URLs
  • make Replace the default and include LoRa only for Replace
  • make Add use ?add=true and omit LoRa so receiver settings are preserved
  • retain reboot feedback for actual region/modem changes

Part of meshtastic/design#128. Fixes #350.

Validation

  • focused channel_share_tests --no-skip: 2 tests, 16 assertions
  • independent review verified the protobuf wire format against the Apple/Android/Web contract

Remaining validation

  • full CMake/CTest was blocked locally by LovyanGFX bootstrap and missing grpc-tools
  • no hardware TFT modal/event-flow validation yet

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2700730-4f1f-403d-8bad-8d832a293b14

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make TFT channel QR sharing interoperable with design #128

1 participant