Commit 65117c0
committed
Address maintainer feedback: reclassify RX paths + restore log detail
Review feedback from @GUVWAF and @Copilot on PR #10252:
1. CRC mismatch (GUVWAF): keep as LOG_INFO (not DEBUG), restore the
full parameter set (id, from, to, flags, SNR, RSSI, nextHop, relay)
— it is valuable info for operators even if it is not ERROR severity.
2. 'from == 0' path (GUVWAF): this is a correctly-received OTA packet
that we refuse to process by policy, not a bad RX. Remove the
rxBad++ / airTime logging I had added; rxGood++ already counts the
OTA reception above.
3. payloadLen < 0 path (GUVWAF): same reasoning — not a bad RX class.
Remove the rxBad++ / airTime additions; retain only the LOG_WARN.
4. Packet pool exhaustion (Copilot): the allocator (Allocator::
allocZeroed) already emits a WARN on failure. Drop the duplicate
LOG_ERROR I had added to avoid log flooding under sustained pressure.
Behaviour now preserved:
- all 4 original bugs still fixed (CRC log volume, randomBytes
off-by-one, from==0 no-deref, pool-exhaustion null-check)
- counter semantics restored to match existing philosophy
- log signal-to-noise improved without dropping useful parameters1 parent 879a5f9 commit 65117c0
1 file changed
Lines changed: 13 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
486 | | - | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
487 | 489 | | |
488 | | - | |
489 | | - | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
490 | 494 | | |
491 | | - | |
492 | 495 | | |
493 | 496 | | |
494 | 497 | | |
| |||
505 | 508 | | |
506 | 509 | | |
507 | 510 | | |
508 | | - | |
509 | | - | |
510 | 511 | | |
511 | | - | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
512 | 515 | | |
513 | 516 | | |
514 | | - | |
515 | | - | |
516 | 517 | | |
517 | 518 | | |
518 | 519 | | |
519 | | - | |
520 | | - | |
521 | 520 | | |
522 | 521 | | |
523 | 522 | | |
524 | 523 | | |
525 | 524 | | |
526 | | - | |
527 | | - | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
528 | 528 | | |
529 | | - | |
530 | 529 | | |
531 | 530 | | |
532 | 531 | | |
| |||
0 commit comments