Commit 8f17900
committed
Address GUVWAF feedback: count short-RX as rxGood + promote invalid-protobuf to WARN
GUVWAF flagged two remaining log/counter items on the hardened RX path:
- RadioLibInterface.cpp: the short-packet branch was neither rxGood nor
rxBad after the previous revision. Move rxGood++ above the
payloadLen<0 check so every CRC-passed OTA reception counts regardless
of subsequent header-validation outcome.
- Router.cpp: 'Invalid protobufs in received mesh packet (bad psk?)' is
more than DEBUG-worthy — either our channel key is wrong or someone's
feeding us corrupted data. Promote to LOG_WARN per GUVWAF's request.
("Invalid portnum" at the same site stays at LOG_DEBUG — that one only
means the decoded protobuf had the default portnum field, which is a
weaker signal.)1 parent 65117c0 commit 8f17900
2 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
505 | 505 | | |
506 | 506 | | |
507 | 507 | | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
508 | 513 | | |
509 | 514 | | |
510 | 515 | | |
511 | 516 | | |
512 | | - | |
513 | 517 | | |
514 | 518 | | |
515 | 519 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
499 | 499 | | |
500 | 500 | | |
501 | 501 | | |
502 | | - | |
| 502 | + | |
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| |||
0 commit comments