Skip to content

Add Find Node buzzer admin action#10755

Open
RCGV1 wants to merge 16 commits into
meshtastic:developfrom
RCGV1:codex/find-node-buzzer
Open

Add Find Node buzzer admin action#10755
RCGV1 wants to merge 16 commits into
meshtastic:developfrom
RCGV1:codex/find-node-buzzer

Conversation

@RCGV1

@RCGV1 RCGV1 commented Jun 20, 2026

Copy link
Copy Markdown
Member

What changed?

Adds a dedicated Find Node admin action for nodes with buzzer hardware:

  • Adds AdminMessage.find_node_request handling to start/stop an audible find-node pattern.
  • Returns find_node_response results for STARTED, STOPPED, NO_BUZZER, and BUZZER_DISABLED.
  • Advertises DeviceMetadata.hasBuzzer so clients can gate the action by capability.
  • Stops an active find-node pattern when local input is pressed on the node.
  • Requires the normal admin/session-passkey path for remote admin use; direct local BLE/USB admin use follows existing local admin behavior.
  • Preserves DeviceConfig reload semantics while ignoring stale deprecated/moved DeviceConfig fields (serial_enabled, is_managed) that older clients can echo back during sync.

Related PRs:

Why did it change?

The phone app needs a clear phone-to-device contract to make a BLE-connected node buzz so the user can find it. A dedicated admin command is safer than overloading send_input_event or ringtone state, because firmware can return explicit capability/error results and can stop the pattern on real local user input.

T1000-E I2C/QMA and GPS fixes were intentionally removed from this PR because those are covered by separate PRs.

Verification

  • trunk fmt ran via the commit hook on the touched files.
  • ~/.platformio/penv/bin/python -m platformio test -e native-macos -f test_admin_radio passed after removing the I2C/GPS scope.
    • native-macos:test_admin_radio [PASSED].
    • 61 test cases, 61 succeeded in 85.677s.
  • Branch diff was rechecked and contains no gps, i2c, qma, t1000, or motion files.

Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@github-actions github-actions Bot added needs-review Needs human review hardware-support Hardware related: new devices or modules, problems specific to hardware labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware-support Hardware related: new devices or modules, problems specific to hardware needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant