Skip to content

fix: declare loop variable sa as const pointer in t5s3_epaper variant#11111

Merged
thebentern merged 2 commits into
developfrom
copilot/fix-check-t5s3-epaper-inkhud-failure
Jul 20, 2026
Merged

fix: declare loop variable sa as const pointer in t5s3_epaper variant#11111
thebentern merged 2 commits into
developfrom
copilot/fix-check-t5s3-epaper-inkhud-failure

Conversation

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

cppcheck static analysis was failing the check (t5s3_epaper_inkhud, esp32s3) CI job due to a [constVariablePointer] style violation.

Change

In src/platform/extra_variants/t5s3_epaper/variant.cpp, the range-for loop variable sa only reads sa->handleInput and never mutates the pointed-to object — const is correct here:

// before
for (NicheGraphics::InkHUD::SystemApplet *sa : inkhud->systemApplets) {

// after
for (const NicheGraphics::InkHUD::SystemApplet *sa : inkhud->systemApplets) {

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

Copilot AI changed the title [WIP] Fix failing GitHub Actions job check (t5s3_epaper_inkhud, esp32s3) fix: declare loop variable sa as const pointer in t5s3_epaper variant Jul 20, 2026
Copilot AI requested a review from thebentern July 20, 2026 22:39
@thebentern
thebentern marked this pull request as ready for review July 20, 2026 22:42
@thebentern
thebentern merged commit 67e2012 into develop Jul 20, 2026
1 check passed
@thebentern
thebentern deleted the copilot/fix-check-t5s3-epaper-inkhud-failure branch July 20, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants