Add Find Node buzzer admin protobufs#956
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds new protobuf contract surface for an admin “find node” buzzer action, including a capability flag in device metadata and corresponding admin request/response messages.
Changes:
- Add
DeviceMetadata.hasBuzzerto advertise whether a node has usable buzzer/audio output for find-node. - Add
AdminMessage.FindNodeRequest/FindNodeResponseand wire them intoAdminMessage.payload_variant. - Add a nanopb option to size
FindNodeResponse.resultas an 8-bit integer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| meshtastic/mesh.proto | Adds DeviceMetadata.hasBuzzer capability flag for clients/firmware to advertise buzzer support. |
| meshtastic/admin.proto | Introduces find-node request/response message types and new AdminMessage variants to start/stop audible patterns. |
| meshtastic/admin.options | Adds nanopb sizing option for the new find-node result enum field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
What does this PR do?
Adds the protobuf contract for a Find Node buzzer action:
AdminMessage.find_node_requeststarts or stops a local audible find-node pattern.AdminMessage.find_node_responsereports whether the request started, stopped, or could not run because the node has no buzzer or buzzer output is disabled.DeviceMetadata.hasBuzzeradvertises whether a node has buzzer/audio output usable by this command.Related PRs:
Checklist before merging
Verification
platformio test -e native-macos -f test_admin_radiocompleted 61/61.6566cd61812af44c5a3e77f01db8f72de0a1020a, and the Apple app simulator build passed.bufis not installed in this environment.Summary by CodeRabbit