BUG: allow $MACOSX_DEPLOYMENT_TARGET to be set to major version only#762
Merged
rgommers merged 3 commits intomesonbuild:mainfrom Jun 11, 2025
Merged
BUG: allow $MACOSX_DEPLOYMENT_TARGET to be set to major version only#762rgommers merged 3 commits intomesonbuild:mainfrom
rgommers merged 3 commits intomesonbuild:mainfrom
Conversation
This has no adverse consequence and makes it impossible to forget to add it to relevant tests, which is important because the tests are not commonly run with the environment variables set, making the failure hard to discover.
Accept version specifiers containing only the major version, for example "11", in addition to the already supported major.minor and major.minor.patch formats, for example "11.0" or "11.0.0".
dnicolodi
force-pushed
the
deployment-target
branch
from
0e150f3 to
6a688b1
Compare
rgommers
added
the
maintenance
rgommers
approved these changes
Jun 11, 2025
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
All LGTM, nice fixes and cleanups, thanks @dnicolodi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.