Skip to content

Commit 909b9f1

Browse files
Merge pull request #10 from elhu/invalid-phone-number-exception
Raise InvalidPhoneNumberException instead of TypeError
2 parents 52ae659 + fa1c335 commit 909b9f1

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

lib/messagebird/client.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ def initialize(errors)
1919
end
2020
end
2121

22+
class InvalidPhoneNumberException < TypeError; end
23+
2224
class Client
2325
attr_reader :access_key
2426

@@ -51,7 +53,7 @@ def request(method, path, params={})
5153
when 200, 201, 204, 401, 404, 405, 422
5254
json = JSON.parse(response.body)
5355
else
54-
raise Net::HTTPServerError.new response.http_version, 'Unknown response from server', response
56+
raise InvalidPhoneNumberException, 'Unknown response from server'
5557
end
5658

5759
# If the request returned errors, create Error objects and raise.
@@ -141,7 +143,7 @@ def voice_message_create(recipients, body, params={})
141143

142144
def lookup(phoneNumber, params={})
143145
Lookup.new(request(:get, "lookup/#{phoneNumber}", params))
144-
end
146+
end
145147

146148
def lookup_hlr_create(phoneNumber, params={})
147149
HLR.new(request(:post, "lookup/#{phoneNumber}/hlr", params))

0 commit comments

Comments
 (0)