fixed the cursor index when filtering list#111
Open
menosbits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In src/components/list.zig, the function updateFilter() sets the List's cursor field to "self.filtered_indices.items.len - 1" — i.e., to the last filtered item — when the cursor field is greater than or equal to filtered_indices.items.len and that length is greater than zero.
This behavior is confusing because it makes it appear as if there is only one filtered item, while there are other items above. You can see the behavior in this video:
Before.changes.mp4
In my view, the correct behavior is to reset the cursor to the first item when the list is filtered. Accordingly, the code has been changed to the following:
This is the behavior after the change:
After.changes.mp4
Nice library, btw. Thanks a lot!