Skip to content

Commit 4aa9cd7

Browse files
Copilotkirklandsign
andcommitted
Fix duplicate "select model" message and improve dialog UX
- Prevent duplicate "To get started, select your desired model" messages by checking if the last message is already this message before adding - Change dialog title from "No Model Selected" to "Please Select a Model" for better UX Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
1 parent fb65864 commit 4aa9cd7

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

  • llm/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo

llm/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/MainActivity.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,10 +461,19 @@ private void askUserToSelectModel() {
461461
ETLogging.getInstance().log(askLoadModel);
462462
runOnUiThread(
463463
() -> {
464-
mMessageAdapter.add(askLoadModelMessage);
465-
mMessageAdapter.notifyDataSetChanged();
464+
// Only add the message if it's not already the last message in the chat
465+
int messageCount = mMessageAdapter.getCount();
466+
Message lastMessage = messageCount > 0 ? mMessageAdapter.getItem(messageCount - 1) : null;
467+
boolean isDuplicate =
468+
lastMessage != null
469+
&& lastMessage.getMessageType() == MessageType.SYSTEM
470+
&& askLoadModel.equals(lastMessage.getText());
471+
if (!isDuplicate) {
472+
mMessageAdapter.add(askLoadModelMessage);
473+
mMessageAdapter.notifyDataSetChanged();
474+
}
466475
new AlertDialog.Builder(this)
467-
.setTitle("No Model Selected")
476+
.setTitle("Please Select a Model")
468477
.setMessage(
469478
"Please select a model and tokenizer from the settings (top right corner) to get started.")
470479
.setPositiveButton(android.R.string.ok, null)

0 commit comments

Comments
 (0)