Skip to content

Commit 8eba66a

Browse files
committed
Fix
1 parent 286a714 commit 8eba66a

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

llm/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/SettingsActivity.java

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ public class SettingsActivity extends AppCompatActivity {
4343
// mSettingsFields is the single source of truth for all settings
4444
public SettingsFields mSettingsFields;
4545

46-
// Store initial settings to detect changes
47-
private SettingsFields mInitialSettingsFields;
48-
4946
private DemoSharedPreferences mDemoSharedPreferences;
5047
public static double TEMPERATURE_MIN_VALUE = 0.0;
5148

@@ -158,9 +155,6 @@ private void setupSettings() {
158155
setBackendSettingMode();
159156
}
160157

161-
// Store initial values for change detection
162-
storeInitialSettings();
163-
164158
setupParameterSettings();
165159
setupPromptSettings();
166160
setupClearChatHistoryButton();
@@ -520,21 +514,13 @@ private String getFilenameFromPath(String uriFilePath) {
520514
return "";
521515
}
522516

523-
private void storeInitialSettings() {
524-
mInitialSettingsFields = new SettingsFields(mSettingsFields);
525-
}
526-
527-
private boolean hasSettingsChanged() {
528-
return !mSettingsFields.equals(mInitialSettingsFields);
529-
}
530-
531517
private void updateLoadModelButtonState() {
532-
// Enable button if settings changed OR if valid pre-filled paths are available
518+
// Enable button only if valid model and tokenizer paths are selected
533519
String modelFilePath = mSettingsFields.getModelFilePath();
534520
String tokenizerFilePath = mSettingsFields.getTokenizerFilePath();
535521
boolean hasValidPaths = modelFilePath != null && !modelFilePath.isEmpty()
536522
&& tokenizerFilePath != null && !tokenizerFilePath.isEmpty();
537-
mLoadModelButton.setEnabled(hasSettingsChanged() || hasValidPaths);
523+
mLoadModelButton.setEnabled(hasValidPaths);
538524
}
539525

540526
private void setBackendSettingMode() {

0 commit comments

Comments
 (0)