LlamaDemo more instrumentation tests#159
Merged
Merged
Conversation
- Add testEmptyPromptSend test to verify send button is disabled when input is empty - Add testStopGeneration test and waitForGenerationComplete helper - Update testSendMessageAndReceiveResponse to wait for full generation completion - Fix send button to be disabled when no text is entered (requires model ready + text) - Add visual distinction for disabled send button (30% alpha when disabled) - Add TextWatcher to track input changes and update button state accordingly
- Add testNoFilesInDirectory test to verify file selection dialogs work - Show helpful message when no model files (.pte) found in directory - Show helpful message when no tokenizer files found in directory - Show helpful message when no data files (.ptd) found in directory - Include adb push instructions in the empty directory dialogs - Fix string comparison bug (use .equals() instead of !=)
- Add testCancelFileSelection: verify canceling file selection preserves state - Add testLoadButtonDisabledState: verify load button requires both model and tokenizer - Add testWhitespaceOnlyPrompt: verify send button disabled for whitespace-only input - Update MainActivity to trim whitespace when checking input validity - Increase generation timeout to 5 minutes for slower devices
meta-cla
Bot
added
the
CLA Signed
lucylq
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and UI improvements to address issues caught by tests