Skip to content

Commit eabccc8

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 113b122 commit eabccc8

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

assets/versions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ PYTORCH_VERSION="2.9.0"
1212
# ROCm/XPU builds vLLM from source (no prebuilt ROCm/XPU wheels available)
1313
VLLM_ROCM_VERSION="v0.10.0"
1414
VLLM_XPU_VERSION="v0.13.0"
15-
# IPEX wheels shipped with vLLM has hard python version requirement
15+
# IPEX wheels shipped with vLLM have hard python version requirement
1616
IPEX_PYTHON_VERSION="3.12"
1717
TORCHSTORE_BRANCH="no-monarch-2026.01.05"
1818
# ROCm/XPU builds these from source (no ROCm/XPU wheels); CUDA uses pyproject pins.

scripts/install_xpu.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ if [ -z "${MONARCH_VERSION:-}" ]; then
4747
log_error "MONARCH_VERSION not set in $VERSIONS_FILE"
4848
exit 1
4949
fi
50+
if [ -z "${IPEX_PYTHON_VERSION:-}" ]; then
51+
log_error "IPEX_PYTHON_VERSION not set in $VERSIONS_FILE"
52+
exit 1
53+
fi
5054

5155
# Defaults (override via environment variables)
5256
FORGE_DEPS_DIR="${FORGE_DEPS_DIR:-$HOME/.cache/torchforge}"
@@ -294,7 +298,7 @@ install_torchstore() {
294298
}
295299

296300
install_torchtitan() {
297-
log_info "Installing torchtitan from tag ${TORCHTITAN_XPU_COMMIT}"
301+
log_info "Installing torchtitan from commit ${TORCHTITAN_XPU_COMMIT}"
298302
python -m pip install "git+https://github.com/pytorch/torchtitan.git@${TORCHTITAN_XPU_COMMIT}"
299303
}
300304

@@ -471,7 +475,7 @@ main() {
471475
install_system_packages "$USE_SUDO"
472476
setup_xpu_env
473477

474-
# vLLM install PyTorch + IPEX + creates constraints
478+
# vLLM installs PyTorch + IPEX + creates constraints
475479
install_vllm_xpu
476480

477481
# Everything below is protected by PIP_CONSTRAINT

0 commit comments

Comments
 (0)