Skip to content

Fix version.txt reading logic for edge cases #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbishekS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix version.txt reading logic for edge cases #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions torchx/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@

# pyre-strict

import os
import importlib.resources

from torchx.util.entrypoints import load


def _version() -> str:
version_file = os.path.join(os.path.dirname(__file__), "version.txt")
with open(version_file, "r") as f:
return f.read().strip()
# use importlib.resources to support zipped packages and single-file executables
return importlib.resources.read_text("torchx", "version.txt").strip()


# Follows PEP-0440 version scheme guidelines
Expand Down
Loading