Fix CUSTOM_NAMED_RESOURCES priority in _load_named_resources#1287
Open
AbishekS wants to merge 1 commit into
Open
Fix CUSTOM_NAMED_RESOURCES priority in _load_named_resources#1287AbishekS wants to merge 1 commit into
AbishekS wants to merge 1 commit into
Conversation
Summary: Swap the unpack order so namespace-scanned plugins form the base layer and the in-tree registries (GENERIC/AWS/CUSTOM) override them on name collision. Previously namespace plugins were unpacked last, so a downstream ``torchx_plugins.named_resources.*`` registration silently shadowed ``CUSTOM_NAMED_RESOURCES`` — including any capability injection the custom layer adds on top of the base factory. After: ``CUSTOM_NAMED_RESOURCES`` wins, matching the docstring contract downstream plugin authors rely on. Differential Revision: D101888085
meta-cla
Bot
added
the
CLA Signed
|
@AbishekS has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101888085. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 96 96
Lines 6820 6820
=======================================
Hits 6288 6288
Misses 532 532
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Swap the unpack order so namespace-scanned plugins form the base layer and the in-tree registries (GENERIC/AWS/CUSTOM) override them on name collision. Previously namespace plugins were unpacked last, so a downstream
torchx_plugins.named_resources.*registration silently shadowedCUSTOM_NAMED_RESOURCES— including any capability injection the custom layer adds on top of the base factory. After:CUSTOM_NAMED_RESOURCESwins, matching the docstring contract downstream plugin authors rely on.Differential Revision: D101888085