test: add ConcurrentSyncInvoke test to reproduce invoke_curl data rac…#737
Closed
Codingisinmyblud wants to merge 2 commits into
Closed
Conversation
d1cb8be to
22297bb
Compare
Author
Member
|
this is the test only without the fix, right? |
Member
|
I'm running the CI to trigger the issue. |
Member
|
It worked, tests are failing with data races and heap-use-after-free, if you PR the fix I will merge it. |
Author
|
Thanks, I am working on the fix now, I'll commit the changes soon hopefully. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I added a test that spawns 4 threads making concurrent synchronous metacallht_s('divide') calls, which would then trigger the data race on the shared invoke_curl handle in function_rpc_interface_invoke.
Fixes #693
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.