Illustration centering on anchor#127
Open
asl97 wants to merge 2 commits into
Open
Conversation
Note: limitation of only being able to render a shape to one SVG Illustration at any one time
for working around limitation of zdog only being able to render a shape to one SVG instance at any one time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this idea of allowing an anchor to be passed to the Illustration's centered instead of just
true.Turns out shape stores and reuse it's own SVG elements, probably for performance, browser limitation of not being able to have same element at multiple location.
Resulting in model not liking to get rendered multiple times, any previously rendered seem to get removed when rendering to a different Illustration instance.
Worked around the issue using this.element.innerHTML = this.element.innerHTML to basically make the SVGs elements be a copy.
Demo https://asl97.github.io/zdog/demos/centered/