Fix existing VG not being activated#153
Conversation
|
Interesting, which OS Distro is on the host ? On our debian/ubuntu workers this is not required. Maybe you can add a check if it is already active and activate only if not. |
CentOS Stream CoreOS 10.0.20260307-0 (Coughlan) - this is a RedHat OKD cluster.
Fair enough, I'll amend the patch in a bit. |
If the VG exists but has inactive LVs - we activate it explicitly.
|
@majst01 I amended the patch to only try to activate the VG if it exists but has non-active LVs. |
Gerrit91
left a comment
There was a problem hiding this comment.
To me looks good, too. Thanks! Parsing the lv_attrs is somehow a bit cryptic but it does not seem like there's a better, more intuitive way to figure this out.
Description
We noticed that on Azure VMs with local NVMe disks, a host reboot did not activate the
csi-lvmvolume group, resulting in PVCs not being attached. We traced it down to a logic error - the driver checks if the volume group exists, but doesn't try to activate it if it does.Used AI-Tools ✨