WIP: Do not hardcode object names to allow multiple csi-diver-lvm s per cluster#154
Conversation
…uster This is needed for example in case if user has many kinds of disks (SSD/HDD/NVME) and wants to choose per PVC what backing solution to use
| args: | ||
| - --v=5 | ||
| - --csi-address=/csi/csi.sock | ||
| - --kubelet-registration-path={{ .Values.kubernetes.kubeletPath }}/plugins/{{ .Values.lvm.storageClassStub }}/csi.sock |
There was a problem hiding this comment.
at least here, it must be ensured the the release.Name does not contain any dangerous characters.
There was a problem hiding this comment.
I am actually planning to create helpers for them
There was a problem hiding this comment.
Release.Name cannot really contain any dangerous characters, the only potentially dangerous character that can exist is a . but that needs to be in the middle of a name so .test or test. is not even allowed. Also only 1 consequent . is allowed(therefore test..test is not allowed). So only test.test is allowed
therefore {{ .Values.kubernetes.kubeletPath }}/plugins/test.test AFAIK should be totally fine and valid plugin folder
Gerrit91
left a comment
Gerrit91
left a comment
There was a problem hiding this comment.
Please convert the PR to draft when it's not yet ready for review. We ignore "WIP". 😅
| - --devices={{ .Values.lvm.devicePattern }} | ||
| - --nodeid=$(KUBE_NODE_NAME) | ||
| - --vgname={{ .Values.lvm.vgName }} | ||
| - --vgname={{ .Release.Name }} |
There was a problem hiding this comment.
This removes independent configuration options?
There was a problem hiding this comment.
I am actually planning to create helpers for them. Idea is to by default generate it(Read: Use .Release.Name) and if it is provided, then use provided one
There was a problem hiding this comment.
independant configuration options are back
Sorry.. I really do not use github any more, it's workflow is unknown to me. I am heavy Gitlab user |
|
No problem. Thanks. :) |
create secrets for encryption by automatically, and preserve them between helm deploys
fix using namespace
3 participants
Description
This is needed for example in case if user has many kinds of disks (SSD/HDD/NVME) and wants to choose per PVC what backing solution to use
Used AI-Tools ✨