Skip to content

Support mount options from the storage class#155

Merged
Gerrit91 merged 1 commit into
metal-stack:masterfrom
tacho:mount-options
May 21, 2026
Merged

Support mount options from the storage class#155
Gerrit91 merged 1 commit into
metal-stack:masterfrom
tacho:mount-options

Conversation

@tacho
Copy link
Copy Markdown
Contributor

@tacho tacho commented May 21, 2026

Description

Standard K8s storage class field for specifying filesystem mount options that was being ignored. This implements support, so options such as noatime, nodelalloc, etc. can be used.

Standard K8s storage class field for specifying filesystem mount options
that was being ignored.
@tacho tacho requested a review from a team as a code owner May 21, 2026 08:39
Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. To me this looks good. Also the Kubernetes documentation says it does not validate the mount options, so I think we don't need to do this either.

@Gerrit91 Gerrit91 requested a review from majst01 May 21, 2026 09:00
@tacho
Copy link
Copy Markdown
Contributor Author

tacho commented May 21, 2026

Cool. To me this looks good. Also the Kubernetes documentation says it does not validate the mount options, so I think we don't need to do this either.

Thanks. Yep, I followed what the the in-tree drivers do.

@Gerrit91 Gerrit91 merged commit 207a16d into metal-stack:master May 21, 2026
6 checks passed
@tacho tacho deleted the mount-options branch May 21, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants