Revert "feat: expose healthiness and readiness checks against metal-api (#124)"#127
Closed
l0wl3vel wants to merge 1 commit into
Closed
Revert "feat: expose healthiness and readiness checks against metal-api (#124)"#127l0wl3vel wants to merge 1 commit into
l0wl3vel wants to merge 1 commit into
Conversation
…pi (#124)" This implementation is subtly borked. Running multiple replicas leads to non-leaders not starting up the probe server leading to crash loops. And the secure serving endpoint registers internal handlers, which we should assume are important. So I am going to redo the probes using secure serving next. This reverts commit 25e28c8.
This was referenced May 20, 2026
Gerrit91
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implementation is subtly borked. Running multiple replicas leads to non-leaders not starting up the probe server leading to crash loops.
And the secure serving endpoint registers internal handlers, which we should assume are important. So I am going to redo the probes using secure serving next.
This reverts commit 25e28c8.
Used AI-Tools ✨