Health probe. Again.#128
Open
l0wl3vel wants to merge 3 commits into
Open
Conversation
…pi (#124)" This implementation is subtly borked. Running multiple replicas leads to non-leaders not starting up the probe server leading to crash loops. And the secure serving endpoint registers internal handlers, which we should assume are important. So I am going to redo the probes using secure serving next. This reverts commit 25e28c8.
l0wl3vel
force-pushed
the
feat/health-probe-v2
branch
from
98d49e9 to
fec1a26
Compare
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
l0wl3vel
force-pushed
the
feat/health-probe-v2
branch
from
f4ee785 to
d079f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement Health Probe. k8s.io/cloud-provider style using secure serving port
Used AI-Tools ✨
Closes #34