Refactor: autoload, OOP cleanup, and spec improvements

[ronaldtse]

Changes

Architecture

• Autoload conversion: All internal require "metanorma/cli/*" converted to Ruby autoload in parent namespace files. Created lib/metanorma/cli/commands.rb for the Commands namespace autoloads.
• FlavorMethods module: cli/flavor.rb converted from reopening the Command class to a proper FlavorMethods module, included via include FlavorMethods.
• ConfigExtractor extraction: The export_config_* methods (~100 lines) extracted from the flavor helpers into a dedicated Metanorma::Cli::ConfigExporter class.

Code Quality

• Removed require_relative "flavor" from command.rb (last require_relative in lib/)
• Removed all internal requires from individual files (autoloaded from namespace files)
• Simplified public_send(:[], h) → acc[h] and public_send(:[]=, ...) → acc[...] = value in Commands::Config
• Replaced manifest[:template]&.public_send(node.to_s) with direct attribute access in SiteGenerator
• Made collection_file? and select_source_collection_files public query methods

Specs

• Replaced double() with instance_double() (type-checked) in collection and compiler specs
• Removed send() on private methods in site_generator_spec
• Added spec for new ConfigExporter class

Note

stringify_all_keys.rb is dead code (require commented out everywhere) — flagged for removal in a follow-up.

[opoudjis]

@ronaldtse Merged main into this (a ton of discrepancies), it failed badly, you will need to get it working. Not to be included in this release, marking as draft until it matures.

As I have no idea what you are doing, merging main into this PR to make it ready for merging is your responsibillity...

[ronaldtse]

@opoudjis this is ready.

[opoudjis]

Pushed f3d79e5 to fix the red CI. The main → branch merge pulled in the #418 (--extensions) and #421/#423 (export-config .xsl/.yaml) work, and three things diverged against the refactor:

1. site_generator_spec.rb — 5 failures (NameError: undefined ... 'output_directory'). The refactor replaced the single top-level let(:output_directory) with per-context copies (#select_source_collection_files, without manifest file, with manifest file, custom site template) but the merged context "with output format extensions" never got one. Added it.

2. export_config_spec.rb — 1 failure (.xsl not exported). Root cause is a duplicated glob list: the new ConfigExporter::FLAVOR_FILE_PATTERNS was a stale copy of flavor.rb's EXPORT_CONFIG_FLAVOR_FILES, predating the .xsl/.yaml globs added in #421/#423. export-config routes through ConfigExporter (command.rb:189), so the flavor.rb copy — which did have the globs — was dead. Synced the globs into the live ConfigExporter list and deleted the dead flavor.rb export methods + constant (no remaining callers) so the duplication can't diverge again. That removal also cleared the 4 rubocop offenses that lived in the dead block.

3. rubocop — 7 offenses. 4 were in the dead flavor.rb block (gone with #2); the other 3 were over-long lines + a redundant Dir.exist? guard in export_config_spec.rb, collapsed into a loop.

Verified locally: config_exporter_spec green, export_config_spec:20 green (exports .xsl + .yaml), rubocop clean on all four files, and the extensions examples now execute past the NameError (they hit a macOS-only Errno::EPERM ./TemporaryItems temp-dir artifact in my local fs that the CI runners don't have — CI will confirm those). The duplication between ConfigExporter and the old flavor.rb path is worth keeping an eye on; collapsing fully onto ConfigExporter is the right end state.

🤖