Merge pull request #579 from Lanayx/master

Don't emit DataType for DateOnly and TimeOny types

Author: mganss

XmlSchemaClassGenerator.Tests/DateOnlyTimeOnlyTests.cs

@@ -72,8 +72,8 @@ public void WhenUseDateOnlyIsTrue_DateOnlyAndTimeOnlyAreGenerated()
 
         Assert.Contains("public System.DateOnly SomeDate", code);
         Assert.Contains("public System.TimeOnly SomeTime", code);
-        Assert.Contains("DataType=\"date\"", code);
-        Assert.Contains("DataType=\"time\"", code);
+        Assert.DoesNotContain("DataType=\"date\"", code);
+        Assert.DoesNotContain("DataType=\"time\"", code);
     }
 
     [Fact]
@@ -191,7 +191,7 @@ public void WhenUseDateOnlyIsFalse_AndDateTimeWithTimeZoneIsTrue_DateTimeOffsetI
         Assert.DoesNotContain("DataType=\"date\"", code);
     }
     [Fact]
-    public void WhenUseDateOnlyIsTrue_AndDateTimeWithTimeZoneIsTrue_DateOnlyAndTimeOnlyAreGenerated_WithDataTypeAttribute()
+    public void WhenUseDateOnlyIsTrue_AndDateTimeWithTimeZoneIsTrue_DateOnlyAndTimeOnlyAreGenerated()
     {
         var xsd = @$"<?xml version=""1.0"" encoding=""UTF-8""?>
 <xs:schema elementFormDefault=""qualified"" xmlns:xs=""http://www.w3.org/2001/XMLSchema"">
@@ -218,7 +218,7 @@ public void WhenUseDateOnlyIsTrue_AndDateTimeWithTimeZoneIsTrue_DateOnlyAndTimeO
 
         Assert.Contains("public System.DateOnly SomeDate", code);
         Assert.Contains("public System.TimeOnly SomeTime", code);
-        Assert.Contains("DataType=\"date\"", code);
-        Assert.Contains("DataType=\"time\"", code);
+        Assert.DoesNotContain("DataType=\"date\"", code);
+        Assert.DoesNotContain("DataType=\"time\"", code);
     }
 }

XmlSchemaClassGenerator/CodeUtilities.cs

@@ -78,7 +78,7 @@ public static string ToBackingField(this string propertyName, string privateFiel
         public static bool? IsDataTypeAttributeAllowed(this XmlSchemaDatatype type, GeneratorConfiguration configuration) => type.TypeCode switch
         {
             XmlTypeCode.AnyAtomicType => false,// union
-            XmlTypeCode.Date or XmlTypeCode.Time when configuration.UseDateOnly => true,
+            XmlTypeCode.Date or XmlTypeCode.Time when configuration.UseDateOnly => false,
             XmlTypeCode.DateTime or XmlTypeCode.Date or XmlTypeCode.Time => !configuration.DateTimeWithTimeZone,
             XmlTypeCode.Base64Binary or XmlTypeCode.HexBinary => true,
             _ => false,