Skip to content

Commit d4d8654

Browse files
committed
tests_hw: Reduce scope of container in GHA
Removes the --priveledged flag from container usage and usb device resets in the b_u585i_iot02a tests. Signed-off-by: Matthew Gee <mgee@iol.unh.edu>
1 parent 72abea0 commit d4d8654

2 files changed

Lines changed: 3 additions & 17 deletions

File tree

.devcontainer/zephyr/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
4242
python3-venv \
4343
python3-tk \
4444
sudo \
45-
usbutils \
4645
wget \
4746
xz-utils \
4847
&& curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \

.github/workflows/hardware-bu585.yml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,6 @@ jobs:
3232
- name: Reset USB Connection
3333
run: sudo usbreset STLINK-V3 # Product name for the b_u585i_iot02a, may have to update if we add additional STM boards to the workflow
3434

35-
setup-container:
36-
name: Setup Zephyr Container
37-
runs-on: zephyr-xlarge-runner
38-
container:
39-
image: ghcr.io/${{ github.repository }}/devcontainer-zephyr:${{ inputs.devcontainer-tag }}
40-
volumes:
41-
- /dev/bus/usb:/dev/bus/usb
42-
options: --user root --privileged --device=/dev/ttyACM0
43-
44-
steps:
45-
- name: Reset USB Connection
46-
run: usbreset STLINK-V3 # Product name for the b_u585i_iot02a, may have to update if we add additional STM boards to the workflow
47-
4835
build-wasm-files:
4936
name: Build .wasm Files
5037
needs: setup-local-runner
@@ -137,7 +124,7 @@ jobs:
137124
- /usr/local/STMicroelectronics/:/usr/local/STMicroelectronics/
138125
- /github/home/STMicroelectronics/:/github/home/STMicroelectronics/
139126
- /dev/bus/usb:/dev/bus/usb
140-
options: --user root --privileged --device=/dev/ttyACM0
127+
options: --user root --device=/dev/ttyACM0
141128

142129
steps:
143130
- name: Clean workspace
@@ -198,7 +185,7 @@ jobs:
198185
- /usr/local/STMicroelectronics/:/usr/local/STMicroelectronics/
199186
- /github/home/STMicroelectronics/:/github/home/STMicroelectronics/
200187
- /dev/bus/usb:/dev/bus/usb
201-
options: --user root --privileged --device=/dev/ttyACM0
188+
options: --user root --device=/dev/ttyACM0
202189

203190
steps:
204191
- name: Clean workspace
@@ -259,7 +246,7 @@ jobs:
259246
- /usr/local/STMicroelectronics/:/usr/local/STMicroelectronics/
260247
- /github/home/STMicroelectronics/:/github/home/STMicroelectronics/
261248
- /dev/bus/usb:/dev/bus/usb
262-
options: --user root --privileged --device=/dev/ttyACM0
249+
options: --user root --device=/dev/ttyACM0
263250

264251
steps:
265252
- name: Clean workspace

0 commit comments

Comments
 (0)