Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Type/DrupalClassResolverReturnType.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ public static function getType(
): Type {
$arg1 = $scope->getType($methodCall->getArgs()[0]->value);
if (count($arg1->getConstantStrings()) === 0) {
// Handle class-string<T> typed variables
$classStringObjectType = $arg1->getClassStringObjectType();
if (count($classStringObjectType->getObjectClassNames()) > 0) {
return $classStringObjectType;
}

return ParametersAcceptorSelector::selectFromArgs(
$scope,
$methodCall->getArgs(),
Expand Down
16 changes: 16 additions & 0 deletions tests/src/Type/data/drupal-class-resolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,22 @@

class Foo {}

function test_class_string_vars(): void {
/** @var class-string<Foo> $fooClass */
$fooClass = Foo::class;
assertType(Foo::class, (new ClassResolver())->getInstanceFromDefinition($fooClass));
assertType(Foo::class, \Drupal::service('class_resolver')->getInstanceFromDefinition($fooClass));
assertType(Foo::class, \Drupal::classResolver()->getInstanceFromDefinition($fooClass));
assertType(Foo::class, \Drupal::classResolver($fooClass));

/** @var class-string<MyService> $serviceClass */
$serviceClass = MyService::class;
assertType(MyService::class, (new ClassResolver())->getInstanceFromDefinition($serviceClass));
assertType(MyService::class, \Drupal::service('class_resolver')->getInstanceFromDefinition($serviceClass));
assertType(MyService::class, \Drupal::classResolver()->getInstanceFromDefinition($serviceClass));
assertType(MyService::class, \Drupal::classResolver($serviceClass));
}

function test(): void {
assertType(Foo::class, (new ClassResolver())->getInstanceFromDefinition(Foo::class));
assertType(Foo::class, \Drupal::service('class_resolver')->getInstanceFromDefinition(Foo::class));
Expand Down
Loading