Skip to content

Commit f80c3cf

Browse files
committed
use valid r-DNS application ID
The Freedesktop.org desktop entry specification recommends an ID "controlled by the author", while the AppStream specification makes it a requirement. The desktop entry uses JFileSync3, and the project internally jfs as inherited from JFileSync. Both are not registered TLDs. io.github.mgoellnitz.JFileSync3 is used as it is guaranteed to be a valid ID through existence of this repo. Link: https://specifications.freedesktop.org/desktop-entry-spec/latest/file-naming.html Link: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
1 parent 862dd98 commit f80c3cf

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ You can start the application through
118118
- a Windows launcher ('JFileSync3.exe')
119119
- a batch file ('bin/JFileSync3.bat')
120120
- a Unix shell script ('bin/JFileSync3')
121-
- a XDG launcher script ('share/applications/JFileSync3.desktop')
121+
- a XDG launcher script ('share/applications/io.github.mgoellnitz.JFileSync3.desktop')
122122

123123
The XDG launcher script can be automatically modified to reflect the current
124124
path with the script `share/prepare_xdg_file.sh`.

xdg/applications/JFileSync3.desktop renamed to xdg/applications/io.github.mgoellnitz.JFileSync3.desktop

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Encoding=UTF-8
33
Name=JFileSync3 - 3.0-SNAPSHOT
44
Comment=Syncing and Encryption
55
Exec=JFileSync3
6-
Icon=JFileSync3
6+
Icon=io.github.mgoellnitz.JFileSync3
77
Categories=Application;Java
88
Version=1.0
99
Type=Application

xdg/icons/hicolor/64x64/apps/JFileSync3.png renamed to xdg/icons/hicolor/64x64/apps/io.github.mgoellnitz.JFileSync3.png

File renamed without changes.

xdg/prepare_desktop_file.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ if [ -f $DIR/../lib/JFileSync3.jar ] ; then
1212
fi
1313
fi
1414
PATTERN=$(echo $DIR|sed -e 's/\//\\\//g')\\/
15-
sed -i.bak -e "s/^Exec=.*/Exec=${PATTERN}\\/bin\\/JFileSync3/" $DIR/share/applications/JFileSync3.desktop
16-
sed -i.bak -e "s/^Icon=.*/Icon=${PATTERN}\\/share\\/icons\\/hicolor\\/64x64\\/apps\\/JFileSync3.png/" $DIR/share/applications/JFileSync3.desktop
15+
sed -i.bak -e "s/^Exec=.*/Exec=${PATTERN}\\/bin\\/JFileSync3/" $DIR/share/applications/io.github.mgoellnitz.JFileSync3.desktop
16+
sed -i.bak -e "s/^Icon=.*/Icon=${PATTERN}\\/share\\/icons\\/hicolor\\/64x64\\/apps\\/io.github.mgoellnitz.JFileSync3.png/" $DIR/share/applications/io.github.mgoellnitz.JFileSync3.desktop
1717
rm $DIR/JFileSync3.desktop.bak
1818
fi

0 commit comments

Comments
 (0)