Prefer unpacking over concatenating

This also opens the door to using more tuples and generators in these places for further optimizations
Used Ruff to prevent regressions

Author: Avasam

Pythonwin/pywin/Demos/ocx/ocxserialtest.py

@@ -68,7 +68,7 @@ def OnComm(self):
 
 class TestSerDialog(dialog.Dialog):
     def __init__(self, *args):
-        dialog.Dialog.__init__(*(self,) + args)
+        dialog.Dialog.__init__(*(self, *args))
         self.olectl = None
 
     def OnComm(self):

Pythonwin/pywin/docking/DockingBar.py

@@ -96,7 +96,7 @@ def CreateWindow(
         self._obj_.CreateWindow(wndClass, title, style, (0, 0, 0, 0), parent, id)
 
         # Create the child dialog
-        self.dialog = childCreator(*(self,) + childCreatorArgs)
+        self.dialog = childCreator(*(self, *childCreatorArgs))
 
         # use the dialog dimensions as default base dimensions
         assert self.dialog.IsWindow(), (

Pythonwin/pywin/framework/editor/color/coloreditor.py

@@ -631,8 +631,9 @@ def GetPythonPropertyPages(self):
         """Returns a list of property pages"""
         from pywin.scintilla import configui
 
-        return EditorTemplateBase.GetPythonPropertyPages(self) + [
-            configui.ScintillaFormatPropertyPage()
+        return [
+            *EditorTemplateBase.GetPythonPropertyPages(self),
+            configui.ScintillaFormatPropertyPage(),
         ]
 
 

Pythonwin/pywin/scintilla/config.py

@@ -175,7 +175,7 @@ def configure(self, editor, subsections=None):
         # First, we "recursively" connect any we are based on.
         if subsections is None:
             subsections = []
-        subsections = [""] + subsections
+        subsections = ["", *subsections]
         general = self.get_data("general")
         if general:
             parents = general.get("based on", [])
@@ -224,7 +224,7 @@ def configure(self, editor, subsections=None):
     def get_key_binding(self, event, subsections=None):
         if subsections is None:
             subsections = []
-        subsections = [""] + subsections
+        subsections = ["", *subsections]
 
         subsection_keymap = self.get_data("keys")
         for subsection in subsections:

Pythonwin/pywin/tools/TraceCollector.py

@@ -38,7 +38,7 @@ def CollectorThread(stopEvent, file):
 
 class WindowOutput(winout.WindowOutput):
     def __init__(self, *args):
-        winout.WindowOutput.__init__(*(self,) + args)
+        winout.WindowOutput.__init__(*(self, *args))
         self.hStopThread = win32event.CreateEvent(None, 0, 0, None)
         _thread.start_new(CollectorThread, (self.hStopThread, self))
 

com/win32com/client/dynamic.py

@@ -209,7 +209,7 @@ def __call__(self, *args):
                 pythoncom.DISPID_VALUE,
             )
         if invkind is not None:
-            allArgs = (dispid, LCID, invkind, 1) + args
+            allArgs = (dispid, LCID, invkind, 1, *args)
             return self._get_good_object_(
                 self._oleobj_.Invoke(*allArgs), self._olerepr_.defaultDispatchName, None
             )
@@ -331,7 +331,7 @@ def __setitem__(self, index, *args):
                 pythoncom.DISPID_VALUE,
             )
         if invkind is not None:
-            allArgs = (dispid, LCID, invkind, 0, index) + args
+            allArgs = (dispid, LCID, invkind, 0, index, *args)
             return self._get_good_object_(
                 self._oleobj_.Invoke(*allArgs), self._olerepr_.defaultDispatchName, None
             )
@@ -354,7 +354,7 @@ def _find_dispatch_type_(self, methodName):
 
     def _ApplyTypes_(self, dispid, wFlags, retType, argTypes, user, resultCLSID, *args):
         result = self._oleobj_.InvokeTypes(
-            *(dispid, LCID, wFlags, retType, argTypes) + args
+            *(dispid, LCID, wFlags, retType, argTypes, *args)
         )
         return self._get_good_object_(result, user, resultCLSID)
 
@@ -447,7 +447,7 @@ def _proc_(self, name, *args):
             item = self._olerepr_.mapFuncs[name]
             dispId = item.dispid
             return self._get_good_object_(
-                self._oleobj_.Invoke(*(dispId, LCID, item.desc[4], 0) + (args))
+                self._oleobj_.Invoke(*(dispId, LCID, item.desc[4], 0, *args))
             )
         except KeyError:
             raise AttributeError(name)

com/win32com/demos/connect.py

@@ -19,8 +19,9 @@
 
 class ConnectableServer(win32com.server.connect.ConnectableServer):
     _public_methods_ = [
-        "DoIt"
-    ] + win32com.server.connect.ConnectableServer._public_methods_
+        "DoIt",
+        *win32com.server.connect.ConnectableServer._public_methods_,
+    ]
     _connect_interfaces_ = [IID_IConnectDemoEvents]
 
     # The single public method that the client can call on us

com/win32com/demos/ietoolbar.py

@@ -98,7 +98,7 @@ def toparam(self):
                     val = default
                 vals.append(val)
             full_fmt += fmt
-        return struct.pack(*(full_fmt,) + tuple(vals))
+        return struct.pack(*(full_fmt, *tuple(vals)))
 
 
 class TBBUTTON(WIN32STRUCT):

com/win32com/server/connect.py

@@ -77,7 +77,7 @@ def _BroadcastNotify(self, broadcaster, extraArgs):
         # Ignores clients that fail.
         for interface in self.connections.values():
             try:
-                broadcaster(*(interface,) + extraArgs)
+                broadcaster(*(interface, *extraArgs))
             except pythoncom.com_error as details:
                 self._OnNotifyFail(interface, details)
 

com/win32com/test/testIterators.py

@@ -137,4 +137,4 @@ def suite():
 
 
 if __name__ == "__main__":
-    unittest.main(argv=sys.argv + ["suite"])
+    unittest.main(argv=[*sys.argv, "suite"])