Merge pull request #7 from mhiro2/fix/list-sessions-notify-when-disabled

fix(commands,persist): Improve session listing UX when persist is disabled

Author: mhiro2

lua/peekstack/commands.lua

@@ -32,7 +32,7 @@ local function session_updated_at_text(session)
   if type(updated_at) ~= "number" then
     return "unknown"
   end
-  return os.date("%Y-%m-%d %H:%M:%S", updated_at)
+  return vim.fn.strftime("%Y-%m-%d %H:%M:%S", updated_at)
 end
 
 ---@return string[]

lua/peekstack/persist/init.lua

@@ -195,10 +195,19 @@ function M.restore(name, opts)
 end
 
 ---List all saved sessions
----@param opts? { on_done?: fun(sessions: table<string, PeekstackSession>) }
+---@param opts? { on_done?: fun(sessions: table<string, PeekstackSession>), silent?: boolean }
 ---@return table<string, PeekstackSession>
 function M.list_sessions(opts)
   local on_done = opts and opts.on_done or nil
+  local silent = opts and opts.silent
+  if silent == nil then
+    -- Synchronous list calls are mostly used for command completion.
+    -- Keep them silent to avoid notification spam when persist is disabled.
+    silent = on_done == nil
+  end
+  if not ensure_enabled(silent) then
+    return {}
+  end
   if on_done then
     store.read(SCOPE, {
       on_done = function(read_data)

tests/commands_spec.lua

@@ -1,22 +1,35 @@
 describe("peekstack.commands", function()
   local commands = require("peekstack.commands")
+  local config = require("peekstack.config")
   local persist = require("peekstack.persist")
   local original_list_sessions = nil
   local original_select = nil
+  local original_notify = nil
+  local original_strftime = nil
 
   before_each(function()
+    config.setup({})
     commands._reset()
     original_list_sessions = persist.list_sessions
     original_select = vim.ui.select
+    original_notify = vim.notify
+    original_strftime = vim.fn.strftime
   end)
 
   after_each(function()
+    config.setup({})
     if original_list_sessions then
       persist.list_sessions = original_list_sessions
     end
     if original_select then
       vim.ui.select = original_select
     end
+    if original_notify then
+      vim.notify = original_notify
+    end
+    if original_strftime then
+      vim.fn.strftime = original_strftime
+    end
     commands._reset()
   end)
 
@@ -69,6 +82,59 @@ describe("peekstack.commands", function()
     assert.equals("broken: 1 items (updated: unknown)", prompts[2])
   end)
 
+  it("notifies when list sessions is invoked while persist is disabled", function()
+    config.setup({ persist = { enabled = false } })
+
+    local messages = {}
+    vim.notify = function(msg)
+      table.insert(messages, msg)
+    end
+
+    commands.setup()
+    vim.api.nvim_cmd({ cmd = "PeekstackListSessions" }, {})
+
+    assert.is_true(vim.list_contains(messages, "peekstack.persist is disabled"))
+  end)
+
+  it("formats session updated_at with vim.fn.strftime", function()
+    local prompts = {}
+    local strftime_calls = {}
+
+    persist.list_sessions = function(opts)
+      assert.is_truthy(opts)
+      assert.is_truthy(opts.on_done)
+      opts.on_done({
+        alpha = {
+          items = {},
+          meta = { updated_at = 123 },
+        },
+      })
+      return {}
+    end
+
+    vim.fn.strftime = function(fmt, ts)
+      table.insert(strftime_calls, { fmt = fmt, ts = ts })
+      return "formatted-time"
+    end
+
+    vim.ui.select = function(_items, opts, on_choice)
+      table.insert(prompts, opts.prompt)
+      if opts.prompt == "Select a session" then
+        on_choice("alpha")
+        return
+      end
+      on_choice("Info only")
+    end
+
+    commands.setup()
+    vim.api.nvim_cmd({ cmd = "PeekstackListSessions" }, {})
+
+    assert.equals(1, #strftime_calls)
+    assert.equals("%Y-%m-%d %H:%M:%S", strftime_calls[1].fmt)
+    assert.equals(123, strftime_calls[1].ts)
+    assert.equals("alpha: 0 items (updated: formatted-time)", prompts[2])
+  end)
+
   it("includes extended providers in quick peek completion", function()
     commands.setup()
     local names = vim.fn.getcompletion("PeekstackQuickPeek ", "cmdline")

tests/persist_sessions_spec.lua

@@ -187,12 +187,28 @@ describe("peekstack.persist.sessions", function()
 
   it("should notify when persist is disabled", function()
     config.setup({ persist = { enabled = false } })
+    local original_notify = vim.notify
+    local messages = {}
+    vim.notify = function(msg)
+      table.insert(messages, msg)
+    end
 
     -- These should not error when persist is disabled
     persist.save_current("test")
     persist.restore("test")
+    local sessions = persist.list_sessions()
+    assert.same({}, sessions)
+    local callback_called = false
+    persist.list_sessions({
+      on_done = function()
+        callback_called = true
+      end,
+    })
+    assert.is_false(callback_called)
     persist.delete_session("test")
     persist.rename_session("a", "b")
+    assert.is_true(vim.list_contains(messages, "peekstack.persist is disabled"))
+    vim.notify = original_notify
   end)
 
   it("should handle non-existent sessions gracefully", function()