Skip to content

feat(ui): Modularize stack view and harden config validation#6

Merged
mhiro2 merged 2 commits into
mainfrom
feat/stack-view-modules-position
Feb 13, 2026
Merged

feat(ui): Modularize stack view and harden config validation#6
mhiro2 merged 2 commits into
mainfrom
feat/stack-view-modules-position

Conversation

@mhiro2

@mhiro2 mhiro2 commented Feb 13, 2026

Copy link
Copy Markdown
Owner

Summary

This PR improves stack view maintainability and UX, and hardens config validation behavior.

Changes

  • Split stack view into submodules (init / render / tree / keymaps) while keeping compatibility via
    ui/stack_view.lua
  • Added configurable stack view panel position: ui.stack_view.position = "left" | "right" | "bottom"
    (default: right)
  • Improved stack view rendering behavior:
    • multibyte-safe help width calculation (strdisplaywidth)
    • parser reuse for preview Tree-sitter highlights (same source buffer)
  • Extended :PeekstackQuickPeek completion with:
    • lsp.declaration
    • diagnostics.in_buffer
    • marks.buffer, marks.global, marks.all
  • Hardened robustness and typing:
    • guard vim.fn.bufadd() return value in popup creation
    • cleaned/improved annotations in stack/persist/init/stack_view
    • updated validate_type() to return and apply fallback defaults

@mhiro2 mhiro2 self-assigned this Feb 13, 2026
@mhiro2 mhiro2 added the enhancement New feature or request label Feb 13, 2026
@mhiro2 mhiro2 merged commit 61aca7f into main Feb 13, 2026
3 checks passed
@mhiro2 mhiro2 deleted the feat/stack-view-modules-position branch February 13, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant