Update jms/serializer-uuid-bundle#12
Conversation
|
ping @mhujer |
|
Hi @p4veI @enumag I was thinking about deprecating this bundle, because all it does is that it registeres a handler in DI. See https://github.com/mhujer/jms-serializer-uuid-bundle/blob/master/src/DependencyInjection/config/services.yml The whole bundle can be replaced with this in services:
Mhujer\JmsSerializer\Uuid\UuidSerializerHandler:
tags:
- { name: jms_serializer.subscribing_handler }I already did similar thing in my fork of consistence-jms-serializer-symfony - just stopped using the bundle and I register the handler manually. What do you think? Registering the handler directly should allow easier updates of JMS library without being blocked by neither of |
|
Agreed, just add it into the readme of https://github.com/mhujer/jms-serializer-uuid. :-) |
|
@enumag I will do it, just wanted to check with you that there isn't any other reason why the bundle may be useful. |
|
Thanks for the info, I've replaced the library anyways, just bumped the deps for others, but you're right using this as a bundle is just an extra overhead. Thanks for your work tho! |
Updates compatibility to support
jms/serializer-bundle:^4.0I'm running into symfony update issues while using the bundle. Seems it would require bumping the jms/serializer requirements in the serializer-uuid library too. (here mhujer/jms-serializer-uuid#13)