refactor: replace schedule_update_ha_state() with async_write_ha_state()#140
Open
jensihnow wants to merge 1 commit into
Open
refactor: replace schedule_update_ha_state() with async_write_ha_state()#140jensihnow wants to merge 1 commit into
jensihnow wants to merge 1 commit into
Conversation
All push-update callbacks were using schedule_update_ha_state() which internally uses call_soon_threadsafe — designed for scheduling work from outside the event loop. Since these callbacks are invoked by HA's dispatcher from within the event loop, the thread-safe hop is unnecessary. Relates to michaelarnauts#139
Owner
|
Are you sure about this? See https://developers.home-assistant.io/docs/core/entity/#subscribing-to-updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All push-update callbacks were using schedule_update_ha_state() which internally uses call_soon_threadsafe — designed for scheduling work from outside the event loop. Since these callbacks are invoked by HA's dispatcher from within the event loop, the thread-safe hop is unnecessary.
Relates to #139