Add advanced controls and diagnostics#152
Open
PrzemyslawKlys wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a few ComfoConnect controls and diagnostics that are already available through the bridge API but were not exposed as Home Assistant entities:
The writable number entities read the min/max/step metadata from the unit before exposing values in Home Assistant.
Notes
This is intentionally separate from #151, which handles alarm surfacing. This PR only contains the advanced controls and diagnostics work.
The changes were tested on an AERISnext 450 R VV through an Evotec fork before opening this upstream PR. The live test read number values, ranges, and steps from the unit without writing settings; the user then installed and tested the merged fork build in Home Assistant.
Validation
python -m ruff check custom_componentspython -m ruff format --check custom_componentspython -m compileall custom_components\comfoconnectaiocomfoconnect==0.1.15