Updates to fix YAML linter's complaining#320
Merged
Merged
Conversation
Added missing bounty name localizations Added missing faction localizations Attached bounty descriptions to proper bounties, added placeholders where no description existed Changed guidebook ids to work with localizations Added localizations for faction guidebook entries Updated two images
github-actions
Bot
added
size/M
S: Needs Review
Changes: No C#
S: Untriaged
and removed
S: Needs Review
size/M
labels
michaelchessall
merged commit c25e8e3
into
michaelchessall:master
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Modified/added a number of yml/ftl files to reduce YAML linter errors. Linter has no errors on my machine
Technical details
Added missing bounty name localizations
Added localizations for faction guidebook entries and changed faction guidebook ids to work with the ftl file
Some bounty descriptions were disconnected from existing bounties, they should now be linked
Bounties with no descriptions had placeholders added. I don't think bounty descriptions are currently visible so I don't believe this should cause problems
Updated two image sources as the old sources appear to have been moved or deleted at some point
Removed markingCategory attribute from persistence additions to human_hair.yml. The markingCategory attribute is used in exactly one largely disconnected go file that was last updated 4 years ago and nowhere else, and furthermore nothing else in the human_hair.yml file has it. I don't believe this removal will cause issues
Re added antagonist guidebook entries for the sole purpose of removing linter errors
Requirements