Fixing Debug/Map Renderer actions#322
Closed
GreyGrisGrey wants to merge 9 commits into
Closed
Conversation
…added a ftl file to reduce map renderer complaints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added a couple small checks to a couple functions to allow github actions to run that were previously consistently returning errors. Relatedly, updated some guidebook/status effect names to reduce warnings and more closely follow naming conventions.
Technical details
Added null check to SpawnPlayer function preventing some null reference errors.
Added contains check to a test also preventing a number of errors.
Added lines to allow certain github actions to be run manually, making testing easier.
Added ftl file containing localizations for some status effects that didn't have them, reducing warnings by a substantial amount.
Updated numerous factions/status names to work with ftl file formatting and more closely match naming conventions.
Requirements