Fix: add checkout step to reusable-fabric-etl workflow#25
Merged
Conversation
Phase 1 extracted inline Python from this workflow into scripts/run_fabric_etl.py but the corresponding actions/checkout step was never added. The other two refactored reusables (reusable-deploy-supported.yml, reusable-deploy-bulk.yml) both have it; only this one was missed. Without checkout, the runner has no scripts/ directory and the python invocation fails with 'No such file or directory'. The Phase 1 refactor's test-environment ETL run looked successful because workflow_run-triggered workflows execute the workflow file from the default branch — at that moment main still held the pre-refactor inline-Python version. The bug surfaced as soon as PR #24 promoted the refactored workflow to main, breaking the next prod ETL run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the Phase 1 refactor (PR #22), the ETL Prod workflow started failing with:
reusable-fabric-etl.ymlwas missing theactions/checkoutstep that the other two refactored reusables already have.Why this slipped past CI
workflow_run-triggered workflows execute the workflow file from the default branch, not the head ref. When PR #23 (dev → test) merged, ETL Test ran the version of the reusable that still lived onmain— the pre-refactor inline-Python version that didn't need a checkout. The bug only surfaced once PR #24 promoted the refactored reusable tomain, breaking the prod ETL run that fired on that same merge.Fix
One step added:
actions/checkout, pinned to the same SHA the deploy workflows use.Failing run for reference
https://github.com/michaeldeongreen/microsoft-fabric-sdlc-patterns/actions/runs/25597178051