fix(record): remove Number() coercion in reload and destroyRecord to support string ids (#246)

* fix(record): remove Number() coercion in reload and destroyRecord to support string ids

* fix(record): remove Number() coercion in reload and destroyRecord to support string ids

Author: michaeljymsgutierrez

packages/dist/arm-js-library.js

@@ -572,7 +572,7 @@ Fix: Try adding ${collectionName} on your ARM config initialization.`;
     return this._request({
       resourceMethod: "delete",
       resourceName: getProperty(currentRecord, "collectionName"),
-      resourceId: Number(getProperty(currentRecord, "id")),
+      resourceId: getProperty(currentRecord, "id"),
       resourceParams: {},
       resourcePayload: null,
       resourceFallback: {},
@@ -593,7 +593,7 @@ Fix: Try adding ${collectionName} on your ARM config initialization.`;
     return this._request({
       resourceMethod: "get",
       resourceName: getProperty(currentRecord, "collectionName"),
-      resourceId: Number(getProperty(currentRecord, "id")),
+      resourceId: getProperty(currentRecord, "id"),
       resourceParams: {},
       resourcePayload: null,
       resourceFallback: {},

packages/src/lib/api-resource-manager.js

@@ -715,7 +715,7 @@ export default class ApiResourceManager {
     return this._request({
       resourceMethod: 'delete',
       resourceName: getProperty(currentRecord, 'collectionName'),
-      resourceId: Number(getProperty(currentRecord, 'id')),
+      resourceId: getProperty(currentRecord, 'id'),
       resourceParams: {},
       resourcePayload: null,
       resourceFallback: {},
@@ -737,7 +737,7 @@ export default class ApiResourceManager {
     return this._request({
       resourceMethod: 'get',
       resourceName: getProperty(currentRecord, 'collectionName'),
-      resourceId: Number(getProperty(currentRecord, 'id')),
+      resourceId: getProperty(currentRecord, 'id'),
       resourceParams: {},
       resourcePayload: null,
       resourceFallback: {},

packages/tests/mirage/index.js

@@ -46,8 +46,11 @@ export default function () {
           : request.requestBody
       })
 
-      this.delete('/addresses/:id', () => {
-        return { data: addresses.data[1] }
+      this.delete('/addresses/:id', (schema, request) => {
+        const { id } = request.params
+        return isNaN(Number(id))
+          ? { data: { id, type: 'addresses', attributes: {} } }
+          : { data: addresses.data[1] }
       })
     },
   })

packages/tests/units/record.js

@@ -158,6 +158,22 @@ const execRecordTest = (ARM) => {
         expect(record.get('attributes.address1')).toBe('Anabu Hills Test 4')
       })
 
+      test('Verify reload with string collection record id', async () => {
+        ARM.pushPayload('addresses', [
+          {
+            id: 'JO-26181S4VPU65',
+            type: 'addresses',
+            attributes: { address1: 'String ID Address', kind: 'office' },
+          },
+        ])
+        const record = ARM.peekRecord('addresses', 'JO-26181S4VPU65')
+        expect(record).toBeDefined()
+
+        const result = await record.reload()
+        expect(result).toBeDefined()
+        expect(record.get('isError')).toBe(false)
+      })
+
       test('Verify rollbackAttributes functionality', async () => {
         await ARM.findRecord('addresses', 2518368, null, {
           autoResolve: false,
@@ -204,6 +220,22 @@ const execRecordTest = (ARM) => {
         expect(ARM.peekRecord('addresses', 2518368)).toBeUndefined()
       })
 
+      test('Verify destroyRecord with string collection record id', async () => {
+        ARM.pushPayload('addresses', [
+          {
+            id: 'JO-26181S4VPU65',
+            type: 'addresses',
+            attributes: { address1: 'String ID Address', kind: 'office' },
+          },
+        ])
+        const record = ARM.peekRecord('addresses', 'JO-26181S4VPU65')
+        expect(record).toBeDefined()
+
+        const result = await record.destroyRecord()
+        expect(result).toBeDefined()
+        expect(ARM.peekRecord('addresses', 'JO-26181S4VPU65')).toBeUndefined()
+      })
+
       test('Verify getCollection functionality', async () => {
         await ARM.query(
           'addresses',