docs(jsdoc): add examples, typedefs, and fix type expressions for public methods#248
Merged
michaeljymsgutierrez merged 3 commits intoJul 5, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three improvements to developer experience and documentation quality across the library:
@exampleblocks, typedefs, and clearer descriptions to every public method in the library sourcedist/arm-js-library.jsand regeneratedtypes/index.d.tsso the improved JSDoc and@exampleblocks are visible in VS Code IntelliSenseGithub Issue: N/A
Changes
README.md
####promoted to###,Collection Recordselevated to top-level##)###subheadings---horizontal rules after headingsdestroyRecordHTTP label (GET->DELETE),groupBystale "Incorrectly" note removed,idtype updated toNumber | String,getAliasparam name corrected,queryRecordparams marked optionalgetAliasandgetRequestAliaspackages/src/lib/api-resource-manager.js@typedef RequestConfigdocumenting all config options (alias,autoResolve,skip,skipId,ignorePayload,override) - previously undocumented@typedef CollectionRecorddocumenting the full runtime record API injected by ARM@exampleblocks to all 21 public instance methods and all 24 utility methods (zero examples existed before)@throwstopushPayload,query,queryRecord,findAll,findRecordidparam types to{number|string}onfindRecordandpeekRecord_saveRecord(UUID-based POST vs PUT logic),pushPayload,setGlobal,setRootScope,getRootScope, and all utility methods{*[]}->{Array.<*>}inuniqandmapBymethod docs (was causingyarn build:jsdocsto fail)packages/dist/arm-js-library.js+packages/types/index.d.tstypes/index.d.tsso@exampleblocks and updated typedefs appear in VS Code IntelliSense hover cardsScreenshots/Images
N/A - no UI changes.
How Has This Been Tested?
yarn test)yarn build:jsdocspasses cleanly after fixing invalid{*[]}type expressions@exampleblocks appear intypes/index.d.tsafter rebuildChecklist
Reviewer Guidance
id - Number | Stringchange in README and JSDoc reflects the v2.9.0 feature that shipped without a docs updatetypes/index.d.tsis auto-generated viayarn build:dts- the source of truth is the JSDoc inapi-resource-manager.js