fix: ci deploy & 404 github pages (#23)

michasdev · web-flow · commit 160ff4defacf · 2026-04-25T23:24:56.000-03:00
diff --git a/.github/workflows/deploy-mildstack-dev.yml b/.github/workflows/deploy-mildstack-dev.yml
@@ -32,7 +32,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './apps/web/www/package-lock.json'
 
@@ -43,12 +43,12 @@ jobs:
         run: npm run build
 
       - name: Add Custom Domain CNAME
-        run: echo "mildstack.dev" > dist/CNAME
+        run: echo "mildstack.dev" > build/client/CNAME
 
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3
         with:
-          path: ./apps/web/www/dist
+          path: ./apps/web/www/build/client
 
   deploy:
     name: Deploy to GitHub Pages
diff --git a/apps/web/www/app/root.tsx b/apps/web/www/app/root.tsx
@@ -47,6 +47,12 @@ export function Layout({ children }: { children: React.ReactNode }) {
         <meta property="twitter:title" content="MildStack - Open Source LocalStack Alternative" />
         <meta property="twitter:description" content="Lightweight, local-first AWS emulator for developers. Fast, simple, and memory-efficient local cloud API." />
         <meta property="twitter:image" content="/og-image.png" />
+        {/* spa-github-pages: restore real URL from 404.html redirect */}
+        <script
+          dangerouslySetInnerHTML={{
+            __html: `(function(l){if(l.search[1]=='/'){var decoded=l.search.slice(1).split('&').map(function(s){return s.replace(/~and~/g,'&')}).join('?');window.history.replaceState(null,null,l.pathname.slice(0,-1)+decoded+l.hash)}}(window.location))`,
+          }}
+        />
         <Meta />
         <Links />
       </head>
diff --git a/apps/web/www/public/404.html b/apps/web/www/public/404.html
@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8">
+    <title>MildStack</title>
+    <script type="text/javascript">
+      // Single Page Apps for GitHub Pages
+      // MIT License
+      // https://github.com/rafgraph/spa-github-pages
+      // This script takes the current url and converts the path and query
+      // string into just a query string, and then redirects the browser
+      // to the new url with only a query string and hash fragment,
+      // e.g. https://www.foo.tld/one/two?a=b&c=d#qwe, becomes
+      // https://www.foo.tld/?/one/two&a=b~and~c=d#qwe
+      // Note: this 404.html file must be at least 512 bytes for it to work
+      // with Internet Explorer (it is currently > 512 bytes)
+
+      // Using a custom domain (mildstack.dev), so pathSegmentsToKeep = 0.
+      // If deploying to username.github.io/repo-name, set to 1.
+      var pathSegmentsToKeep = 0;
+
+      var l = window.location;
+      l.replace(
+        l.protocol + '//' + l.hostname + (l.port ? ':' + l.port : '') +
+        l.pathname.split('/').slice(0, 1 + pathSegmentsToKeep).join('/') + '/?/' +
+        l.pathname.slice(1).split('/').slice(pathSegmentsToKeep).join('/').replace(/&/g, '~and~') +
+        (l.search ? '&' + l.search.slice(1).replace(/&/g, '~and~') : '') +
+        l.hash
+      );
+    </script>
+  </head>
+  <body>
+  </body>
+</html>
