Skip to content

Commit d53f66c

Browse files
committed
fix: macos app signing
1 parent 75d8b9f commit d53f66c

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

.github/workflows/desktop-build.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,15 @@ jobs:
130130
if: matrix.platform == 'mac'
131131
shell: bash
132132
run: |
133-
mapfile -t app_paths < <(find apps/desktop/dist -maxdepth 3 -type d -name "MildStack Desktop.app" | sort)
134-
if [[ ${#app_paths[@]} -eq 0 ]]; then
133+
app_paths="$(find apps/desktop/dist -maxdepth 3 -type d -name "MildStack Desktop.app" | sort)"
134+
if [[ -z "$app_paths" ]]; then
135135
echo "No macOS app bundle found under apps/desktop/dist"
136136
exit 1
137137
fi
138138
139-
for app_path in "${app_paths[@]}"; do
139+
while IFS= read -r app_path; do
140+
[[ -z "$app_path" ]] && continue
140141
echo "Verifying: $app_path"
141142
codesign --verify --deep --strict --verbose=2 "$app_path"
142143
codesign -dv --verbose=4 "$app_path" 2>&1 | sed -n '1,40p'
143-
done
144+
done <<< "$app_paths"

.github/workflows/mildstack-release.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,17 +175,18 @@ jobs:
175175
if: matrix.platform == 'mac'
176176
shell: bash
177177
run: |
178-
mapfile -t app_paths < <(find apps/desktop/dist -maxdepth 3 -type d -name "MildStack Desktop.app" | sort)
179-
if [[ ${#app_paths[@]} -eq 0 ]]; then
178+
app_paths="$(find apps/desktop/dist -maxdepth 3 -type d -name "MildStack Desktop.app" | sort)"
179+
if [[ -z "$app_paths" ]]; then
180180
echo "No macOS app bundle found under apps/desktop/dist"
181181
exit 1
182182
fi
183183
184-
for app_path in "${app_paths[@]}"; do
184+
while IFS= read -r app_path; do
185+
[[ -z "$app_path" ]] && continue
185186
echo "Verifying: $app_path"
186187
codesign --verify --deep --strict --verbose=2 "$app_path"
187188
codesign -dv --verbose=4 "$app_path" 2>&1 | sed -n '1,40p'
188-
done
189+
done <<< "$app_paths"
189190
190191
- name: Upload packaged release artifacts
191192
if: startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch'

apps/desktop/electron-builder.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ mac:
2727
# Force ad-hoc signing so app binary and bundled frameworks share a consistent signature
2828
# when no Apple Developer ID is available.
2929
identity: "-"
30+
forceCodeSigning: false
3031
entitlementsInherit: build/entitlements.mac.plist
3132
extendInfo:
3233
- NSCameraUsageDescription: Application requests access to the device's camera.
@@ -40,10 +41,6 @@ mac:
4041
arch:
4142
- x64
4243
- arm64
43-
- target: zip
44-
arch:
45-
- x64
46-
- arm64
4744
dmg:
4845
artifactName: ${name}-${version}-mac-${arch}.${ext}
4946
linux:

0 commit comments

Comments
 (0)