Open
Conversation
There was a problem hiding this comment.
5 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/remote-host/smoke.sh">
<violation number="1" location="tests/remote-host/smoke.sh:44">
P2: This smoke command never exercises the remote SSH launch path: `SSH_CONFIG_FILE` is unused and `--dry-run` skips running the editor, so the test can pass without validating the temporary host setup.</violation>
</file>
<file name="src/main.rs">
<violation number="1" location="src/main.rs:87">
P2: This check misses remote/config combinations inherited from history, so `recent` can silently ignore a config when reopening a remote workspace.</violation>
</file>
<file name="tests/remote-host/docker-compose.yml">
<violation number="1" location="tests/remote-host/docker-compose.yml:9">
P2: Bind the test SSH port to localhost so the smoke harness does not expose it beyond the machine running the test.</violation>
</file>
<file name="src/workspace.rs">
<violation number="1" location="src/workspace.rs:303">
P2: Reject user-supplied `--folder-uri` in remote classic mode before appending your own.</violation>
</file>
<file name="src/launch.rs">
<violation number="1" location="src/launch.rs:165">
P1: Remote SSH launches silently ignore `--behavior force-container` and fall back to a plain remote open.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main.rs">
<violation number="1" location="src/main.rs:193">
P1: Default remote reopens from `recent` will error on entries that were previously opened locally with the default `detect` behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
2 issues found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main.rs">
<violation number="1" location="src/main.rs:200">
P2: This now rejects `recent --remote-host` for history entries that merely have a stored `config_path`, even when the user did not pass `--config` in this invocation.</violation>
</file>
<file name="tests/remote-host/smoke.sh">
<violation number="1" location="tests/remote-host/smoke.sh:55">
P3: Assert the full fake-editor argv instead of grepping individual lines.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openandrecent, generatingvscode-remote://ssh-remote+...URIs and persisting the remote host in historyvscli