add support for basic findOne with ID#154
Open
intellix wants to merge 1 commit intomickhansen:masterfrom
Open
Conversation
496214f to
df251f1
Compare
df251f1 to
0f1cd4f
Compare
Contributor
Author
|
let me know what you think @mickhansen - if there's anything I need to defend or test against and if you like the BATCH_BY_ATTRIBUTE stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following on from #147
I decided to see if Claude could help me fix the test, since this work is so valuable to us and it seems to have it all passing.
Supports dataloading for cases such as:
Also, it adds a new BATCH_BY_ATTRIBUTE to easily batch by another attribute like a foreignKey: