Skip to content

Commit 940d13b

Browse files
authored
Replace API deprecated in Foxy (#21)
Since the deprecated API was removed in Rolling, this change should fix the failure here: http://build.ros2.org/view/Rbin_uF64/job/Rbin_uF64__system_modes_examples__ubuntu_focal_amd64__binary/12/ Signed-off-by: Jacob Perron <jacob@openrobotics.org>
1 parent f9b2a69 commit 940d13b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

system_modes_examples/src/drive_base.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class DriveBase : public LifecycleNode
6666
}
6767
return result;
6868
};
69-
this->set_on_parameters_set_callback(param_change_callback);
69+
param_change_callback_handle_ = this->add_on_set_parameters_callback(param_change_callback);
7070
}
7171

7272
DriveBase(const DriveBase &) = delete;
@@ -103,6 +103,9 @@ class DriveBase : public LifecycleNode
103103

104104
return rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::SUCCESS;
105105
};
106+
107+
private:
108+
rclcpp::Node::OnSetParametersCallbackHandle::SharedPtr param_change_callback_handle_;
106109
};
107110

108111
} // namespace examples

system_modes_examples/src/manipulator.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class Manipulator : public LifecycleNode
6363
}
6464
return result;
6565
};
66-
this->set_on_parameters_set_callback(param_change_callback);
66+
param_change_callback_handle_ = this->add_on_set_parameters_callback(param_change_callback);
6767
}
6868

6969
Manipulator(const Manipulator &) = delete;
@@ -100,6 +100,9 @@ class Manipulator : public LifecycleNode
100100

101101
return rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::SUCCESS;
102102
};
103+
104+
private:
105+
rclcpp::Node::OnSetParametersCallbackHandle::SharedPtr param_change_callback_handle_;
103106
};
104107

105108
} // namespace examples

0 commit comments

Comments
 (0)