Add persist_logs bool and integrate throughout the config flow

Add many logger.info chunks for testing

Author: SteveMicroNova

amplipi/app.py

@@ -24,6 +24,7 @@
 
 import argparse
 
+import configparser
 import logging
 import sys
 
@@ -238,9 +239,35 @@ def shutdown():
     }
   )
 def log_persistance(ctrl: Api = Depends(get_ctrl)):
+  """Toggles log persistance by directly changing the journald.conf and restarting the service"""
   try:
-    ctrl.toggle_log_persist()
+    logger.info("log_persistance called!")
+    conf_path = '/etc/systemd/journald.conf'
+
+    config = configparser.ConfigParser(strict=False, allow_no_value=True)
+    config.read(conf_path)
+
+    if 'Journal' not in config:
+      config.add_section('Journal')
+
+    logger.info(f"Perist logs is {ctrl.persist_logs} before")
+    if ctrl.persist_logs:  # Reset config to default as seen in configure.py
+      config.set('Journal', 'Storage', 'volatile')
+      config.set('Journal', 'RuntimeMaxUse', '64M')
+      config.set('Journal', 'ForwardToConsole', 'no')
+      config.set('Journal', 'ForwardToWall', 'no')
+      ctrl.persist_logs = False
+      logger.info("log_persistance deactivated!")
+    else:  # Set persist
+      config.set('Journal', 'Storage', 'persistant')
+      config.set('Journal', 'SyncIntervalSec', '30s')
+      config.set('Journal', 'SystemMaxUse', '64M')
+      ctrl.persist_logs = True
+      logger.info("log_persistance activated!")
+    logger.info(f"Perist logs is {ctrl.persist_logs} after")
+    os.system('sudo systemctl restart systemd-journald')
   except Exception as e:
+    logger.error("log_persistance failed!")
     raise e
 
 

amplipi/ctrl.py

@@ -32,7 +32,6 @@
 import sys
 import datetime
 
-import configparser
 import threading
 import wrapt
 
@@ -124,7 +123,7 @@ class Api:
   status: models.Status
   streams: Dict[int, amplipi.streams.AnyStream]
   lms_mode: bool
-  persist_logs: bool
+  persist_logs: bool = False
   _serial: Optional[int] = None
   _expanders: List[int] = []
   _freeze_delete_temporary: bool = False
@@ -248,6 +247,7 @@ def reinit(self, settings: models.AppSettings = models.AppSettings(), change_not
       config_file=self.config_file,
       is_streamer=self.is_streamer,
       lms_mode=self.lms_mode,
+      persist_logs=self.persist_logs,
       version=utils.detect_version(),
       stream_types_available=amplipi.streams.stream_types_available(),
       extra_fields=utils.load_extra_fields(),
@@ -1448,27 +1448,3 @@ def play_media(self, media: models.PlayMedia) -> ApiResponse:
     self.set_source(media.source_id, src_update, internal=True, force_update=True)
 
     return ApiResponse.ok()
-
-  def toggle_log_persist(self):
-    """Toggles log persistance by directly changing the journald.conf and restarting the service"""
-    conf_path = '/etc/systemd/journald.conf'
-
-    config = configparser.ConfigParser(strict=False, allow_no_value=True)
-    config.read(conf_path)
-
-    if 'Journal' not in config:
-      config.add_section('Journal')
-
-    if self.persist_logs:  # Reset config to default as seen in configure.py
-      config.set('Journal', 'Storage', 'volatile')
-      config.set('Journal', 'RuntimeMaxUse', '64M')
-      config.set('Journal', 'ForwardToConsole', 'no')
-      config.set('Journal', 'ForwardToWall', 'no')
-      self.persist_logs = False
-    else:  # Set persist
-      config.set('Journal', 'Storage', 'persistant')
-      config.set('Journal', 'SyncIntervalSec', '30s')
-      config.set('Journal', 'SystemMaxUse', '64M')
-      self.persist_logs = True
-
-    os.system('sudo systemctl restart systemd-journald')

amplipi/models.py

@@ -965,6 +965,7 @@ class Info(BaseModel):
   latest_release: str = Field(default='unknown', description='Latest software release available from GitHub')
   access_key: str = Field(default='', description='session token/API key used for authentication')
   lms_mode: bool = Field(default=False, description='Are we running in LMS mode?')
+  persist_logs: bool = Field(default=False, description='Are saving logs to disc?')
   serial: str = Field(default=False, description='Serial Number of this AmpliPi')
   expanders: List[str] = Field(default=[], description='Serial Numbers of any expanders connected to this AmpliPi')
   fw: List[FirmwareInfo] = Field(
@@ -987,6 +988,7 @@ class Config:
             'latest_release': '0.3.4',
             'access_key': '',
             'lms_mode': False,
+            'persist_logs': False,
             'serial': '212',
             'expanders': ['112', '113'],
             'fw': [
@@ -1080,6 +1082,7 @@ class Config:
                      'mock_streams': False,
                      'is_streamer': False,
                      'lms_mode': False,
+                     'persist_logs': False,
                      'online': True,
                      'stream_types_available': ['fmradio', 'internetradio'],
                      'version': '0.1.9'},